Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add disabled states to all input components #3030

Merged
merged 4 commits into from
Jan 28, 2025
Merged

Add disabled states to all input components #3030

merged 4 commits into from
Jan 28, 2025

Conversation

david0xd
Copy link
Contributor

@david0xd david0xd commented Jan 22, 2025 •
edited
Loading

Add disabled state to all input-related Snaps UI components.

Related task: MetaMask/metamask-extension#29669

Extension integration PR: MetaMask/metamask-extension#29896

Screenshot 2025-01-24 at 16 35 56

Screen.Recording.2025-01-24.at.16.53.37.mov

@david0xd david0xd self-assigned this Jan 22, 2025
@david0xd david0xd mentioned this pull request Jan 24, 2025
Draft
7 tasks
@david0xd david0xd force-pushed the dd/add-disabled-states branch from 9a3d1a6 to 06893f3 Compare January 24, 2025 15:38
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@codecov Codecov
Copy link

codecov bot commented Jan 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.80%. Comparing base (c348998) to head (a2e93c2).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3030   +/-   ##
=======================================
  Coverage   94.80%   94.80%           
=======================================
  Files         503      503           
  Lines       10996    10996           
  Branches     1685     1685           
=======================================
  Hits        10425    10425           
  Misses        571      571

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@david0xd david0xd marked this pull request as ready for review January 24, 2025 15:58
@david0xd david0xd requested a review from a team as a code owner January 24, 2025 15:58
@david0xd david0xd force-pushed the dd/add-disabled-states branch from 0471a57 to a2ec7ba Compare January 27, 2025 11:22
@david0xd david0xd force-pushed the dd/add-disabled-states branch from a2ec7ba to a2e93c2 Compare January 28, 2025 10:48
@david0xd david0xd merged commit 01ff383 into main Jan 28, 2025
167 checks passed
@david0xd david0xd deleted the dd/add-disabled-states branch January 28, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrederikBolding FrederikBolding FrederikBolding approved these changes

Assignees

@david0xd david0xd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@david0xd @FrederikBolding